Try to resolve graphql schema loading race conditions in Jest
ClosedPublic
Actions

Authored by dish on Nov 20 2020, 9:34 PM.

Details

Reviewers

bengotow
sashank

Commits

R1:5aff8e9d7868: Try to resolve graphql schema loading race conditions in Jest

Summary

I keep running into Jest race conditions that seem related to loading the schema.graphql file. I haven't really figured out what's going on, it just appears that the Apollo cache is somehow being written with certain fields missing.

This is a bit of a shot in the dark, as I haven't seen any GH issues that quite match what I'm seeing here.

Test Plan

Jest

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dish created this revision.Nov 20 2020, 9:34 PM

Harbormaster completed remote builds in B21509: Diff 26100.Nov 20 2020, 9:38 PM

dish requested review of this revision.Nov 20 2020, 9:38 PM

How is it any different to move the function call outside of the function?

As I said, shot in the dark. I'm kind of at a loss to understand what's broken here. Given that loader doesn't appear to be async, I'm not sure why one thing works and another doesn't.

sashank accepted this revision.Nov 23 2020, 5:42 PM

This revision is now accepted and ready to land.Nov 23 2020, 5:42 PM

Closed by commit R1:5aff8e9d7868: Try to resolve graphql schema loading race conditions in Jest (authored by dish). · Explain WhyNov 23 2020, 9:35 PM

This revision was automatically updated to reflect the committed changes.

dish added a commit: R1:5aff8e9d7868: Try to resolve graphql schema loading race conditions in Jest.