Page MenuHomePhabricator

Fix schreenshots test: Part 1
Needs ReviewPublic

Authored by yichendai on Fri, Nov 20, 9:13 PM.

Details

Reviewers
max
sashank
yuhan
Summary

Update all the screenshots for pictures in the Tutorials of Docs; not including images in Overviews.

Plan to add tests for images in Overview in Part 2 diff.

Test Plan

run docs.dagster.io locally to see if images match texts.

Diff Detail

Repository
R1 dagster
Branch
docspic
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Add a test for custom_types_bad_5 in expectation result and fix docs not aligned with screenshots due to Dagit UI changed

yichendai retitled this revision from Fix schreenshots test to Fix schreenshots test: Part 1.Sat, Nov 21, 12:51 AM
yichendai edited the summary of this revision. (Show Details)
yichendai edited the test plan for this revision. (Show Details)
yichendai edited the summary of this revision. (Show Details)

Update image for playground view in execute first pipeline

Change all the executeButton definition

Update: Allow a hover error to be seen and fix all the new URLs