Page MenuHomePhabricator

add general_tests to windows tests
ClosedPublic

Authored by dgibson on Fri, Nov 20, 12:34 AM.

Details

Summary

These were not included for some reason. Adding them revealed a bug! We had no heartbeats for gRPC servers on windows.

Test Plan

BK + Azure

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Fri, Nov 20, 5:46 PM

It looks like there's also daemon_tests and utils_tests that we want to run

daemon_tests is already there, i think utils_tests is under general_tests?

This revision was automatically updated to reflect the committed changes.