Page MenuHomePhabricator

fixup repo code pointer
AbandonedPublic

Authored by prha on Thu, Nov 19, 10:04 PM.

Details

Reviewers
dgibson
Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

prha requested review of this revision.Thu, Nov 19, 10:19 PM

nice thanks for fixing this up - see API suggestion but I don't feel strongly - depends on how much we think dagit needs to know about the specifics of these repositories.

js_modules/dagit/src/RepositoryInformation.tsx
42–47

part of me wonders if in graphql this should just be exposed directly as key-value metadata like it was before on codepointer - since they're all presented equally and we do seem to change them frequently

Like if we add docker origins in the future or something, maybe it just exposes key-value pairs here? just something to consider

python_modules/dagster-graphql/dagster_graphql/schema/external.py
90–91

consider keeping the metadata key-value pairs from code pointer here?

This revision is now accepted and ready to land.Fri, Nov 20, 2:38 PM