Page MenuHomePhabricator

Futher configured cleanup
ClosedPublic

Authored by schrockn on Thu, Nov 19, 4:54 PM.

Details

Summary

This makes a couple changes

  1. No longer relying on kwargs. Instead we have name and description

arguments to configured

  1. Adding description to some definitions which did not have them
  2. Common helper method for nodes to conditionally grab name from

decorated function.

Depends on D5192

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Nov 19, 5:08 PM
Harbormaster failed remote builds in B21413: Diff 25977!
schrockn edited the summary of this revision. (Show Details)
schrockn edited the test plan for this revision. (Show Details)
schrockn added reviewers: sandyryza, alangenfeld.

up

i can merge this with previous one if desired.

py2 failures expected. will land on fri

This revision is now accepted and ready to land.Fri, Nov 20, 6:17 PM
This revision was automatically updated to reflect the committed changes.