Page MenuHomePhabricator

[dagit] Use /solids for individual solid views
ClosedPublic

Authored by dish on Thu, Nov 19, 4:31 PM.

Details

Summary

Use the full /solids page for all individual solids views. The "typeExplorer" links currently don't work (or seem to mean anything) in an individual solid view, and it seems like we may as well show everything when looking at individual solids anyway.

This fixes the typeExplorer links in individual solid views, and makes the virtualized list scroll directly to the selected solid.

Test Plan

View solids for a repository. Click on types, verify that they lead to the correct filtered view.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dish requested review of this revision.Thu, Nov 19, 4:36 PM

New behavior: just use the full Solids list for viewing individual solids

dish retitled this revision from [dagit] Fix type explorer link on TypeWithTooltip to [dagit] Use /solids for individual solid views.Thu, Nov 19, 4:46 PM
dish edited the summary of this revision. (Show Details)

Remove test for removed route

It does seem to be duplicative when you're in the Solids view in the left nav...

But altogether it seems good to have a denser view when arriving from a deep-link.

This revision is now accepted and ready to land.Thu, Nov 19, 5:14 PM
This revision was automatically updated to reflect the committed changes.