can't add 1 to None this aint php/js
not sure how to produce a repro of this - open to ideas
Don't need this here since we don't use it
unfortunately that query does a group by event type, so all the restart events get grouped. we need to be able to count each restart event
which is why it's down here with materializations and step expectation results, where you can also have > 1 of the event type per step key
maybe do 1, maybe leave a comment?
|207–212 ↗||(On Diff #26001)|
_count should get bumped, no? Did you make sure this test failed without the fix?
But couldn't you add a count to the selection and just use that?
by_step_query = ( db.select( [ SqlEventLogStorageTable.c.step_key, SqlEventLogStorageTable.c.dagster_event_type, db.func.max(SqlEventLogStorageTable.c.timestamp).label("timestamp"), db.func.count(SqlEventLogStorageTable.c.id).label("count"), ] ) .where(SqlEventLogStorageTable.c.run_id == run_id) .where(SqlEventLogStorageTable.c.step_key != None) .where(SqlEventLogStorageTable.c.dagster_event_type.in_(STEP_STATS_EVENT_TYPES)) )