should we assume 1 instead of 0 here ? Im still not sure how we got a restart without a start event

hmm

[1]

we don't need this... we can just add the count to the by_step_query in line 232, right?

Don't need this here since we don't use it

unfortunately that query does a group by event type, so all the restart events get grouped. we need to be able to count each restart event

which is why it's down here with materializations and step expectation results, where you can also have > 1 of the event type per step key

But couldn't you add a count to the selection and just use that?

e.g.

by_step_query = (
    db.select(
        [
            SqlEventLogStorageTable.c.step_key,
            SqlEventLogStorageTable.c.dagster_event_type,
            db.func.max(SqlEventLogStorageTable.c.timestamp).label("timestamp"),
            db.func.count(SqlEventLogStorageTable.c.id).label("count"),
        ]
    )
    .where(SqlEventLogStorageTable.c.run_id == run_id)
    .where(SqlEventLogStorageTable.c.step_key != None)
    .where(SqlEventLogStorageTable.c.dagster_event_type.in_(STEP_STATS_EVENT_TYPES))
)

good call