Page MenuHomePhabricator

(dagit-reload-4) Dagit location reloading UI
ClosedPublic

Authored by sashank on Wed, Nov 18, 7:46 PM.

Details

Summary

This diff introduces the UI in Dagit to monitor updating repository locations.

Test Plan

run dagit with 2 grpc servers, test all the various scenarios:

  • update grpc server with new ID
  • udpate grpc server with same ID
  • grpc server errored out
  • reload grpc server and do all of the above ^

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Nov 18, 8:00 PM
Harbormaster failed remote builds in B21340: Diff 25899!

Remove server status state tracking

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Nov 18, 9:45 PM
Harbormaster failed remote builds in B21358: Diff 25917!
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Nov 18, 10:13 PM
Harbormaster failed remote builds in B21368: Diff 25927!
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Nov 18, 10:52 PM
Harbormaster failed remote builds in B21374: Diff 25934!
sashank retitled this revision from Dagit to [WIP] (dagit-reload-3) Dagit location reloading UI.Thu, Nov 19, 5:18 PM
sashank edited the summary of this revision. (Show Details)
sashank edited the test plan for this revision. (Show Details)
sashank added reviewers: dish, alangenfeld.
sashank added inline comments.
js_modules/dagit/src/nav/StateObserver.tsx
35 ↗(On Diff #25934)

TODO: Rebase and update with new custom network-only query

sashank edited the summary of this revision. (Show Details)
sashank retitled this revision from [WIP] (dagit-reload-3) Dagit location reloading UI to [WIP] (dagit-reload-4) Dagit location reloading UI.Thu, Nov 19, 5:32 PM
sashank edited the test plan for this revision. (Show Details)

network only query

sashank retitled this revision from [WIP] (dagit-reload-4) Dagit location reloading UI to (dagit-reload-4) Dagit location reloading UI.Fri, Nov 20, 6:20 PM
sashank retitled this revision from (dagit-reload-4) Dagit location reloading UI to [WIP] (dagit-reload-4) Dagit location reloading UI.

up

sashank edited the summary of this revision. (Show Details)

up

sashank retitled this revision from [WIP] (dagit-reload-4) Dagit location reloading UI to (dagit-reload-4) Dagit location reloading UI.Fri, Nov 20, 7:04 PM

seems legit - once you get tests passing

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_watch_grpc_server.py
12

TextSubscribe

is this a bit or a typo

python_modules/dagster-test/dagster_test/toys/workspace.yaml
3–8 ↗(On Diff #26081)

dont commit this?

This revision is now accepted and ready to land.Mon, Nov 23, 4:31 PM