Page MenuHomePhabricator

[dagit] Fix schedule name truncation in left nav
ClosedPublic

Authored by dish on Tue, Nov 17, 11:46 PM.

Details

Summary

Resolves #3232

Repair schedule name truncation on the left nav by using an ellipsis for overflow. Also used some Box on the item component to stretch its legs a bit.

Test Plan

View left nav with schedules running and not running, verify proper rendering. Force a schedule name to be very long, verify that it truncates properly.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dish requested review of this revision.Tue, Nov 17, 11:53 PM

thumbs-up-resign

looks reasonable enough to me, but will let ben/prha do the signoff :)

This revision is now accepted and ready to land.Wed, Nov 18, 6:25 PM