Page MenuHomePhabricator

remove "opt_in" parameter from instance, consolidate duplicative managed gRPC test cases
ClosedPublic

Authored by dgibson on Tue, Nov 17, 1:30 AM.

Details

Summary

removed a few places where we were still implying there was a difference between the default flow and the gRPC server flow, now that the managed gRPC server flow is the default flow.

Test Plan

BK + Azure

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Nov 17, 1:46 AM
Harbormaster failed remote builds in B21246: Diff 25773!
This revision is now accepted and ready to land.Tue, Nov 17, 3:17 PM
python_modules/dagster/dagster/core/instance/config.py
58

we may want to keep this around, I just hit this this morning since i have the opt-in

dagster.core.errors.DagsterInvalidConfigError: Errors whilst loading dagster instance config at dagster.yaml.
    Error 1: Received unexpected config entry "opt_in" at the root. Expected: "{ compute_logs?: { class: String config?: { } module: String } event_log_storage?: { class: String config?: { } module: String } local_artifact_storage?: { class: String config?: { } module: String } run_coordinator?: { class: String config?: { } module: String } run_launcher?: { class: String config?: { } module: String } run_storage?: { class: String config?: { } module: String } schedule_storage?: { class: String config?: { } module: String } scheduler?: { class: String config?: { } module: String } telemetry?: { enabled?: Bool } }".