Page MenuHomePhabricator

[dagit] Schedule permalink
ClosedPublic

Authored by dish on Nov 16 2020, 11:38 PM.

Details

Summary

Resolves #3230

Create a permalink page for individual schedules, with metadata and recent runs for that schedule.

Test Plan

View individual schedule, verify proper rendering and behavior.

  • Toggle schedule on/off, verify success
  • View config dialog
  • Navigate to playground

Diff Detail

Repository
R1 dagster
Branch
dish-schedule-view
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

dish created this revision.

Remove changes to defaultMocks

dish requested review of this revision.Nov 16 2020, 11:46 PM

ah sorry this might be an annoying rebase with my schedulerroot/schedulesroot change

js_modules/dagit/src/schedules/ScheduleDetails.tsx
56

could name the repository?

100–103

I realized after the meeting there is one place we use this ID currently - the SystemCronScheduler writes logs to DAGSTER-HOME/logs/<schedule ID> . The new scheduler does not do this. But maybe worth keeping around for now

This revision is now accepted and ready to land.Nov 18 2020, 3:49 PM

Incorporate dgibson's changes, make some visual tweaks

Some visual changes to /scheduler:

This revision was automatically updated to reflect the committed changes.