Paths

Table of Contentst

Differential D5165

[dagit] Schedule permalink
ClosedPublic
Actions

Authored by dish on Nov 16 2020, 11:38 PM.

Tags

None

Subscribers

None

Details

Reviewers

dgibson
johann
prha
bengotow

Commits

R1:6578d9425028: [dagit] Schedule permalink

Summary

Resolves #3230

Create a permalink page for individual schedules, with metadata and recent runs for that schedule.

Test Plan

View individual schedule, verify proper rendering and behavior.

Toggle schedule on/off, verify success
View config dialog
Navigate to playground

Diff Detail

Repository

Branch

dish-schedule-view

Lint

Lint OK

Unit

No Unit Test Coverage

Event Timeline

Remove changes to defaultMocks

Harbormaster completed remote builds in B21242: Diff 25769.Nov 16 2020, 11:43 PM

Harbormaster completed remote builds in B21243: Diff 25770.Nov 16 2020, 11:46 PM

dish requested review of this revision.Nov 16 2020, 11:46 PM

dish edited the summary of this revision. (Show Details)Nov 17 2020, 10:55 PM

ah sorry this might be an annoying rebase with my schedulerroot/schedulesroot change

js_modules/dagit/src/schedules/ScheduleDetails.tsx
56	could name the repository?
100–103	I realized after the meeting there is one place we use this ID currently - the SystemCronScheduler writes logs to DAGSTER-HOME/logs/<schedule ID> . The new scheduler does not do this. But maybe worth keeping around for now

This revision is now accepted and ready to land.Nov 18 2020, 3:49 PM

Incorporate dgibson's changes, make some visual tweaks

Some visual changes to /scheduler:

Harbormaster completed remote builds in B21334: Diff 25889.Nov 18 2020, 6:41 PM

Closed by commit R1:6578d9425028: [dagit] Schedule permalink (authored by dish). · Explain WhyNov 18 2020, 7:18 PM

This revision was automatically updated to reflect the committed changes.

dish added a commit: R1:6578d9425028: [dagit] Schedule permalink.

Revision Contents
Changeset List

Path

Size

js_modules/

dagit/

src/

schedules/

ScheduleDetails.tsx

292 lines

ScheduleRoot.tsx

142 lines

ScheduleRow.tsx

12 lines

SchedulesRoot.tsx

178 lines

types/

PreviousRunsForScheduleQuery.ts

testing/

defaultMocks.ts

4 lines

ui/

MetadataTable.tsx

46 lines

2 lines

16 lines

workspace/

WorkspaceRepoRoot.tsx

4 lines

WorkspaceRoot.tsx

11 lines

Diff 25769

js_modules/dagit/src/schedules/ScheduleDetails.tsx

Loading...

js_modules/dagit/src/schedules/ScheduleRoot.tsx

Loading...

js_modules/dagit/src/schedules/ScheduleRow.tsx

Loading...

js_modules/dagit/src/schedules/SchedulesRoot.tsx

Loading...

js_modules/dagit/src/schedules/types/PreviousRunsForScheduleQuery.ts

Loading...

js_modules/dagit/src/testing/defaultMocks.ts

Loading...

js_modules/dagit/src/ui/MetadataTable.tsx

Loading...

js_modules/dagit/src/ui/Page.tsx

Loading...

js_modules/dagit/src/ui/Text.tsx

Loading...

js_modules/dagit/src/workspace/WorkspaceRepoRoot.tsx

Loading...

js_modules/dagit/src/workspace/WorkspaceRoot.tsx

Loading...