Page MenuHomePhabricator

[dagster-ge] pin great-expectations
ClosedPublic

Authored by alangenfeld on Mon, Nov 16, 8:19 PM.

Details

Summary

unexpressed s3fs dep in this version

>>> import great_expectations.datasource.batch_kwargs_generator
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/alangenfeld/venvs/dagenv38/lib/python3.8/site-packages/great_expectations/datasource/batch_kwargs_generator/__init__.py", line 8, in <module>
    from. s3_subdir_reader_batch_kwargs_generator import S3SubdirReaderBatchKwargsGenerator
  File "/Users/alangenfeld/venvs/dagenv38/lib/python3.8/site-packages/great_expectations/datasource/batch_kwargs_generator/s3_subdir_reader_batch_kwargs_generator.py", line 7, in <module>
    import s3fs
ModuleNotFoundError: No module named 's3fs'

https://github.com/great-expectations/great_expectations/issues/2050

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Nov 16, 8:39 PM
This revision was automatically updated to reflect the committed changes.