Details

Reviewers

sashank
dish
alangenfeld
prha

Commits

R1:6cf7de95cf56: Merge scheduler page and schedules page

Summary

This diff makes the scheduler page and the schedules-for-a-repository page use the same UI. The only difference is that the scheduler page is not repository-scoped.

Both pages show a list of schedules and a list of unloadable schedules. The scheduler page groups the schedules by repository.

In particular there are no longer any prompts to reconcile. The only reconcile-like experience you have now is the 'delete a now-unloadable schedule' experience.

Test Plan

BK
Load a repo with two repositories, visit scheduler page and schedules page for each repository
Turn some schedules on and off, leave some on
Remove a running schedule from the codebase
Visit scheduler page and schedules page for both repos again, verify you can turn off the no longer existant schedule
Load dagit with empty workspace, see all running schedules available on scheduler page to turn off

Diff Detail

Repository

R1 dagster

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dgibson created this revision.Nov 13 2020, 8:37 PM

Harbormaster completed remote builds in B21154: Diff 25662.Nov 13 2020, 8:51 PM

dgibson requested review of this revision.Nov 13 2020, 8:51 PM

Harbormaster completed remote builds in B21158: Diff 25668.Nov 13 2020, 9:42 PM

Harbormaster completed remote builds in B21159: Diff 25669.Nov 13 2020, 9:50 PM

up, ready for review

Harbormaster failed remote builds in B21161: Diff 25671!Nov 13 2020, 10:33 PM

Harbormaster completed remote builds in B21164: Diff 25674.Nov 13 2020, 10:38 PM

This looks great! Awesome to see that reconcile UI go away :)

js_modules/dagit/src/schedules/SchedulerRoot.tsx
46–52	I think this should never be true, since we're not passing in a repository selector argument to this field. Still, it's probably good to check for it, but we might want to show a different invalid state than "Repository not found" because it doesn't really make sense here. It's more like "something went wrong in the Dagster framework itself"
104–105	Nit/Tip: You can alias this name right here in the GQL query instead of needing to do it in JS, so that the field name here makes a bit more sense: unLoadableScheduleStates: scheduleStatesOrError(withNoScheduleDefinition: true) { ... } Then above you can do: const { scheduler, repositoriesOrError, unLoadableScheduleStates, } = result;
js_modules/dagit/src/schedules/SchedulesRoot.tsx
171	Nit: Extra space