Page MenuHomeElementl

[dagit] Upgrade CodeMirror, fix error rendering
ClosedPublic

Authored by dish on Nov 13 2020, 5:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 15, 5:38 AM
Unknown Object (File)
Mon, Sep 12, 12:23 AM
Unknown Object (File)
Fri, Sep 9, 10:08 PM
Unknown Object (File)
Wed, Sep 7, 1:52 PM
Unknown Object (File)
Sep 5 2022, 10:57 AM
Unknown Object (File)
Sep 3 2022, 8:35 AM
Unknown Object (File)
Sep 2 2022, 10:56 PM
Unknown Object (File)
Aug 7 2022, 8:58 AM
Subscribers
None

Details

Summary

A minor upgrade to CodeMirror, but mostly this fixes a bug with how errors are displayed. A CodeMirror change introduced a new way of setting classes on lint marks, so we just need to reflect that in our own code.

Relevant CM change: https://github.com/codemirror/CodeMirror/commit/18aa69e17cc7703f106fbe03992456b8e59e8cdc#diff-01477ffc2e6f10be0f276fcf2243cc3312b9165b00775ebccf7daf937fcef522

Test Plan

View Playground in Dagit with errors, verify that backgrounds render correctly.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable