Page MenuHomePhabricator

Pull refactoring/cleanup off experimental EP branch
ClosedPublic

Authored by bengotow on Jul 2 2019, 6:21 PM.

Details

Summary

Hey folks - I did some cleanup of the existing execution plan on the branch where I was working on the experimental Gaant view. Just pulling the bits that can be merged now so that the new structured log viewer can build on these changes and not cause merge conflicts later.

There are only two slight visual changes on this branch - I fixed the placement of the divider and added a bit of padding in one place in the execution plan where they seemed to be missing.

Test Plan

JS snapshot tests updated

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bengotow created this revision.Jul 2 2019, 6:21 PM
bengotow edited the summary of this revision. (Show Details)Jul 2 2019, 6:23 PM
bengotow added reviewers: alangenfeld, schrockn.
This revision is now accepted and ready to land.Jul 2 2019, 6:25 PM
This revision was landed with ongoing or failed builds.Jul 2 2019, 7:08 PM
This revision was automatically updated to reflect the committed changes.