- Missing test coverage on the 'launch after cleaning up server case'
- wait for the process to clean up before leaving the ExecuteRun API call
Details
Details
- Reviewers
alangenfeld max prha johann - Commits
- R1:9727252f739b: grpc ExecuteRun api call fixes
BK + Azure
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Branch
- grpccomputelogssadtimes (branched from master)
- Lint
Lint Passed - Unit
No Test Coverage
Event Timeline
python_modules/dagster/dagster/serdes/ipc.py | ||
---|---|---|
61–63 ↗ | (On Diff #25570) | nit: looking forward towards type hinting, is it worth making this Noneable instead of updating the callsite |
Comment Actions
should we just get rid of ExecuteRun in favor of StartRun ? - just request review if I missed the callsite thats still using it