Page MenuHomePhabricator

grpc ExecuteRun api call fixes
ClosedPublic

Authored by dgibson on Thu, Nov 12, 7:48 PM.

Details

Summary
  • Missing test coverage on the 'launch after cleaning up server case'
  • wait for the process to clean up before leaving the ExecuteRun API call
Test Plan

BK + Azure

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

what still uses ExecuteRun ? I thought things used StartRun now

python_modules/dagster/dagster/serdes/ipc.py
61–63 ↗(On Diff #25570)

nit: looking forward towards type hinting, is it worth making this Noneable instead of updating the callsite

should we just get rid of ExecuteRun in favor of StartRun ? - just request review if I missed the callsite thats still using it

This revision now requires changes to proceed.Thu, Nov 12, 8:57 PM

hold off til after release to land just to be safe but im pretty sure this is good

This revision is now accepted and ready to land.Thu, Nov 12, 10:28 PM
This revision was automatically updated to reflect the committed changes.