Page MenuHomePhabricator

[sensors-6] add cli test command
ClosedPublic

Authored by prha on Thu, Nov 12, 5:11 PM.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Nov 12, 5:27 PM
Harbormaster failed remote builds in B21064: Diff 25548!
prha requested review of this revision.Sat, Nov 14, 12:41 AM
dgibson added inline comments.
python_modules/dagster/dagster/cli/sensor.py
26

test is probably fine, but consider preview or dry_run as well?

256–258

--since?

help text should probably specify the format and that its a timestamp

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_sensor_commands.py
98–108

can we get test coverage on the --last-modified parameter as well?

This revision is now accepted and ready to land.Tue, Nov 17, 3:50 PM
This revision was automatically updated to reflect the committed changes.