Page MenuHomePhabricator

improve type check failure message
ClosedPublic

Authored by alangenfeld on Wed, Nov 11, 10:24 PM.

Details

Summary

going to make a diff to remove name on DagsterType and just have display_name, but for now just fix this

resolves #2405

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Nov 11, 10:38 PM
Harbormaster failed remote builds in B21019: Diff 25494!
prha added inline comments.
python_modules/dagster/dagster/core/execution/plan/execute_step.py
168–169

nit, maybe add a comma or a dash before "expected"

This revision is now accepted and ready to land.Thu, Nov 12, 4:52 PM
This revision was automatically updated to reflect the committed changes.