This diff adds a GetServerId that exposes a unique UUID associated with each server. This is used to help track gRPC servers updating.
Details
Details
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Branch
- d-reload-1
- Lint
Lint Passed - Unit
No Test Coverage
Event Timeline
Comment Actions
why separate instead of Ping including it?
Just to keep Ping intact since it's useful in basic tests and being able to save a few characters from not have to extract the server id from the ping response every time you call it. Happy to move it around.
Comment Actions
no strong opinion on separate API vs. Ping, GetServerId seems reasonable to me
python_modules/dagster/dagster_tests/general_tests/grpc_tests/test_ping.py | ||
---|---|---|
146–150 | any particular reason this is an inner function? | |
152–155 | you could also use GrpcServerProcess for this, but this is fine too | |
159 | api_client.shutdown_server() would also work |
python_modules/dagster/dagster_tests/general_tests/grpc_tests/test_ping.py | ||
---|---|---|
152–175 |