(dagit-reload-1/n) Add GetServerId gRPC service method
ClosedPublic
Actions

Authored by sashank on Nov 11 2020, 9:03 PM.

Details

Reviewers

alangenfeld
dgibson
prha
max

Commits

R1:99e5ab3ea580: (dagit-reload-1/n) Add GetServerId gRPC service method

Summary

This diff adds a GetServerId that exposes a unique UUID associated with each server. This is used to help track gRPC servers updating.

Test Plan

unit

Diff Detail

Repository

R1 dagster

Branch

d-reload-1

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

sashank created this revision.Nov 11 2020, 9:03 PM

sashank added a child revision: D5106: (dagit-reload-2/n) gRPC server watch thread.Nov 11 2020, 9:06 PM

Harbormaster completed remote builds in B21013: Diff 25486.Nov 11 2020, 9:35 PM

sashank requested review of this revision.Nov 11 2020, 9:35 PM

sashank added reviewers: alangenfeld, dgibson, prha, max.Nov 12 2020, 4:10 PM

sashank edited the summary of this revision. (Show Details)Nov 12 2020, 4:17 PM

why separate instead of Ping including it?

why separate instead of Ping including it?

Just to keep Ping intact since it's useful in basic tests and being able to save a few characters from not have to extract the server id from the ping response every time you call it. Happy to move it around.

no strong opinion on separate API vs. Ping, GetServerId seems reasonable to me

python_modules/dagster/dagster_tests/general_tests/grpc_tests/test_ping.py
146–150	any particular reason this is an inner function?
152–155	you could also use GrpcServerProcess for this, but this is fine too
159	api_client.shutdown_server() would also work