Page MenuHomePhabricator

(dagit-reload-1/n) Add GetServerId gRPC service method
ClosedPublic

Authored by sashank on Wed, Nov 11, 9:03 PM.

Details

Summary

This diff adds a GetServerId that exposes a unique UUID associated with each server. This is used to help track gRPC servers updating.

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

why separate instead of Ping including it?

why separate instead of Ping including it?

Just to keep Ping intact since it's useful in basic tests and being able to save a few characters from not have to extract the server id from the ping response every time you call it. Happy to move it around.

no strong opinion on separate API vs. Ping, GetServerId seems reasonable to me

python_modules/dagster/dagster_tests/general_tests/grpc_tests/test_ping.py
145–149

any particular reason this is an inner function?

151–154

you could also use GrpcServerProcess for this, but this is fine too

158

api_client.shutdown_server() would also work

This revision is now accepted and ready to land.Thu, Nov 12, 9:58 PM
sashank edited the summary of this revision. (Show Details)

clean up toys + remove inner function

sounds good - probably best to be explicit

python_modules/dagster/dagster_tests/general_tests/grpc_tests/test_ping.py
152–175