Differential D5092

temp
AbandonedPublicDraft
Actions

Authored by sashank on Nov 11 2020, 6:50 AM.

Tags

None

Subscribers

None

Details

Reviewers: None

Test Plan

unit
load workspace pointed at remote grpc server, kill server, make sure it reconnects

Diff Detail

Repository

Branch

grpc-demo

Lint

Lint Errors

Severity	Location	Code	Message
Error	python_modules/dagster/dagster/grpc/client.py:412	E0102	Function Redefined
Warning	python_modules/dagster-graphql/dagster_graphql/implementation/context.py:27	W0002	Print Call
Warning	python_modules/dagster-graphql/dagster_graphql/schema/external.py:15	W0611	Unused Import
Warning	python_modules/dagster-graphql/dagster_graphql/schema/external.py:49	W0212	Protected Access
Warning	python_modules/dagster/dagster/core/host_representation/handle.py:196	W0002	Print Call
Warning	python_modules/dagster/dagster/core/host_representation/handle.py:203	W0125	Using Constant Test
Warning	python_modules/dagster/dagster/core/host_representation/handle.py:204	W0002	Print Call
Warning	python_modules/dagster/dagster/core/host_representation/handle.py:256	W0107	Unnecessary Pass
Warning	python_modules/dagster/dagster/core/host_representation/handle.py:268	W0002	Print Call
Warning	python_modules/dagster/dagster/grpc/client.py:4	W0611	Unused Import
Warning	python_modules/dagster/dagster_tests/general_tests/grpc_tests/test_ping.py:9	W0611	Unused Import

Unit

No Unit Test Coverage

Event Timeline

sashank created this revision.Nov 11 2020, 6:50 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 11 2020, 7:07 AM

Harbormaster failed remote builds in B20972: Diff 25437!

sashank abandoned this revision.Dec 1 2020, 4:40 AM

Revision Contents
Changeset List

Path

Size

examples/

legacy_examples/

dagster_examples/

experimental/

5 lines

js_modules/

dagit/

src/

nav/

138 lines

types/

HandleStateChangeSubscription.ts

18 lines

types/

python_modules/

dagster-graphql/

dagster_graphql/

implementation/

32 lines

schema/

38 lines

6 lines

dagster-test/

dagster_test/

toys/

3 lines

dagster/

dagster/

core/

host_representation/

161 lines

35 lines

grpc/

__generated__/

api_pb2_grpc.py

15 lines

protos/

6 lines

9 lines

dagster_tests/

general_tests/

grpc_tests/

64 lines

Diff 25437

examples/legacy_examples/dagster_examples/experimental/workspace.yaml

Loading...

js_modules/dagit/src/nav/LeftNav.tsx

Loading...

js_modules/dagit/src/nav/types/HandleStateChangeSubscription.ts

Loading...

js_modules/dagit/src/schema.graphql

Loading...

js_modules/dagit/src/types/globalTypes.ts

Loading...

python_modules/dagster-graphql/dagster_graphql/implementation/context.py

Loading...

python_modules/dagster-graphql/dagster_graphql/schema/external.py

Loading...

python_modules/dagster-graphql/dagster_graphql/schema/roots.py

Loading...

python_modules/dagster-test/dagster_test/toys/workspace.yaml

Loading...

python_modules/dagster/dagster/core/host_representation/handle.py

Loading...

python_modules/dagster/dagster/core/host_representation/state.py

Loading...

python_modules/dagster/dagster/grpc/generated/api_pb2.py

Loading...

python_modules/dagster/dagster/grpc/generated/api_pb2_grpc.py

Loading...

python_modules/dagster/dagster/grpc/client.py

Loading...

python_modules/dagster/dagster/grpc/protos/api.proto

Loading...

python_modules/dagster/dagster/grpc/server.py

Loading...

python_modules/dagster/dagster_tests/general_tests/grpc_tests/test_ping.py

Loading...