[dagit] Fix Run page overscrolling
ClosedPublic
Actions

Authored by dish on Nov 10 2020, 10:17 PM.

Details

Reviewers

bengotow
prha
sashank

Commits

R1:2be6c502ccd8: [dagit] Fix Run page overscrolling

Summary

Resolves #3207

Looks like I probably broke this with my instance route refactor. Prevent page-level scrolling on the Run page.

Test Plan

View Run, verify that scrolling behaves properly.

Diff Detail

Repository

R1 dagster

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dish created this revision.Nov 10 2020, 10:17 PM

Harbormaster completed remote builds in B20959: Diff 25424.Nov 10 2020, 10:25 PM

dish requested review of this revision.Nov 10 2020, 10:25 PM

dish added reviewers: prha, sashank.Nov 11 2020, 2:09 PM

prha accepted this revision.Nov 11 2020, 4:38 PM

This revision is now accepted and ready to land.Nov 11 2020, 4:38 PM

Closed by commit R1:2be6c502ccd8: [dagit] Fix Run page overscrolling (authored by dish). · Explain WhyNov 11 2020, 5:44 PM

This revision was automatically updated to reflect the committed changes.

dish added a commit: R1:2be6c502ccd8: [dagit] Fix Run page overscrolling.

Revision Contents
Changeset List

Path

Size

js_modules/

dagit/

src/

runs/

RunRoot.tsx

1 line

Diff 25459

View Options

js_modules/dagit/src/runs/RunRoot.tsx

[dagit] Fix Run page overscrollingClosedPublicActions