Page MenuHomeElementl

GCSComputeLogManager
ClosedPublic

Authored by alangenfeld on Nov 10 2020, 10:03 PM.

Details

Summary

this came up in #general and also we will likely want to use it in our google deploy. Effectively a port of the S3ComputeLogManager

Test Plan

tests ported from s3 compute log manager

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

see one comment, otherwise lgtm

python_modules/libraries/dagster-gcp/dagster_gcp_tests/gcs_tests/test_compute_log_manager.py
65

hm, should this be ported?

This revision is now accepted and ready to land.Nov 10 2020, 11:08 PM

Somewhat satisfying how similar the implementations are between AWS / GCS.

python_modules/libraries/dagster-aws/dagster_aws/s3/compute_log_manager.py
124–125

I guess this is because of the expiration?

good catch.

python_modules/libraries/dagster-aws/dagster_aws/s3/compute_log_manager.py
124–125

yep - meant to call this out

python_modules/libraries/dagster-gcp/dagster_gcp_tests/gcs_tests/test_compute_log_manager.py
65

loloops

This revision was automatically updated to reflect the committed changes.