Page MenuHomeElementl

Migrate all non test launch_run calls to submit_run
ClosedPublic

Authored by johann on Nov 6 2020, 5:49 PM.

Details

Summary

Move scheduler, backfills, triggers to use the run coordinator

Test Plan

integration

existing

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

johann retitled this revision from Migrate launch_run calls to submit to Migrate all non test launch_run calls to submit_run.Nov 6 2020, 5:50 PM
johann added reviewers: dgibson, alangenfeld.
johann added inline comments.
python_modules/dagster/dagster/core/instance/__init__.py
1122

Should we deprecate launch_run and add _launch_run?

johann requested review of this revision.Nov 6 2020, 6:08 PM

only question i have is should we be asserting now in submit_run that there's a pipeline origin set? So that it's not possible to get in a state where you turn on a new run coordinator and it breaks b/c there's some callsite that we missed that isn't setting the pipelien origin that it needs to work?

python_modules/dagster/dagster/core/instance/__init__.py
1122

could also rename to launch_run_from_run_coordinator or something.

Or move this into the run coordinator or RunLauncher base class

This revision is now accepted and ready to land.Nov 6 2020, 8:00 PM

submit_run checks external pipeline origin

Fix submit runs with origins