Page MenuHomePhabricator

RFC improve invalid config error messages
ClosedPublic

Authored by alangenfeld on Wed, Nov 4, 9:01 PM.

Details

Summary

Attempt to use more user friendly language to describe invalid configuration

resolves #3161

Test Plan

buildkite - updated test call sites

fumbled around in dagit playground generating config errors, experience felt consistent and error messages read as useful

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tons of tests are going to fail on match so just request review and dial the language first

main question is how to refer to a chunk of run config, the premise of this diff is Field is terribly confusing

  • config entry
  • config section
  • config value

yall got ideas?

update dagit to display all errors

alangenfeld added inline comments.
js_modules/dagit/src/execute/RunPreview.tsx
260–262

@dish / @bengotow - was this intentional ? seems like a more consistent UX if we always show the errors in the list

yichendai removed a subscriber: yichendai.
yichendai added a subscriber: yichendai.

main question is how to refer to a chunk of run config, the premise of this diff is Field is terribly confusing

  • config entry
  • config section
  • config value

yall got ideas?

Upvote for config entry. The message is much clearer to me now 😀

alangenfeld edited the test plan for this revision. (Show Details)

test fixes

prha requested changes to this revision.Mon, Nov 9, 5:20 PM

Test failure looks legit (need to update pandas test?). Returning to your queue.

This revision now requires changes to proceed.Mon, Nov 9, 5:20 PM
This revision is now accepted and ready to land.Mon, Nov 9, 5:31 PM