Page MenuHomePhabricator

Use instance_for_test everywhere we are using DagsterInstance.local_temp
ClosedPublic

Authored by dgibson on Tue, Nov 3, 8:20 PM.

Details

Summary

instance_for_test is a contextmanager that automatically does resource cleanup, particularly if the test involves launching any runs. Several sources of flakiness over the last week can be traced back to tests using local_temp and flaking out due to hanging gRPC servers / threads. This diff rips off the bandaid and moves all local_temp callsites to instance_for_test.

Test Plan

BK + Azure

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Nov 3, 8:49 PM
Harbormaster failed remote builds in B20742: Diff 25144!
This revision is now accepted and ready to land.Wed, Nov 4, 3:33 PM
This revision was landed with ongoing or failed builds.Wed, Nov 4, 4:03 PM
This revision was automatically updated to reflect the committed changes.