Page MenuHomePhabricator

[sensors-1] redefine schedules as jobs
ClosedPublic

Authored by prha on Tue, Nov 3, 7:45 PM.

Details

Summary

Rips out the old job definitions, builds schedules on top of jobs.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha requested review of this revision.Tue, Nov 3, 8:02 PM
dgibson added inline comments.
python_modules/dagster/dagster/core/definitions/job.py
11–12

what are the other planned types? SENSOR, any others?

37–38

should it say something about them being grouped? like what links the series together?

python_modules/dagster/dagster/core/definitions/repository.py
272–276

maybe put this above the schedule check? hard to see where exactly it unindents currently

python_modules/dagster/dagster/core/definitions/schedule.py
30

did not know you could do this with namedtuples

184–189

this logic wasn't important?

This revision is now accepted and ready to land.Tue, Nov 3, 9:33 PM
python_modules/dagster/dagster/core/definitions/job.py
11–12

I think just SENSOR

37–38

It's grouped by job_name.... I'll add something more here.

python_modules/dagster/dagster/core/definitions/schedule.py
184–189

hmm, I need to split out the user-provided tags and system-provided tags to put the checks in the right place

prha marked an inline comment as not done.

update

This revision was automatically updated to reflect the committed changes.