Page MenuHomePhabricator

Re-enable telemetry in tests by default
ClosedPublic

Authored by dgibson on Oct 30 2020, 6:55 PM.

Details

Summary
  • To avoid contention issues, add an additional cleanup step that closes the rotating file handler so that we can safely remove the temp dir in tests
  • To fix the windows telemetry upload test, call this cleanup method before doing the upload in the telemetry upload test
  • Raise exceptions in the telemetry upload test, the catching of all errors was masking some issues with the mock
  • Despite all this, py27 cli tests were still having issues. I think windows py27 just has some significant challenges with filesystem contention, so I disabled that block. I think we should maybe consider just not including py27+windows in our test matrix given that it's on its last legs and is unlikely to be a significant portion of usage?
Test Plan

BK + Azure

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rexledesma added inline comments.
azure-pipelines.yml
18

deferring to @max on this removal

This revision is now accepted and ready to land.Oct 30 2020, 7:32 PM
This revision was landed with ongoing or failed builds.Nov 1 2020, 3:38 PM
This revision was automatically updated to reflect the committed changes.