Page MenuHomePhabricator

asset-store-dagit-2 show asset store info in Definition tab
Changes PlannedPublicDraft

Authored by yuhan on Thu, Oct 29, 5:43 PM.

Details

Summary

show asset_store_key and asset_metadata in Definition's Outputs section
wrapped it in AssetStoreContainer component as we will probably add more info there as the asset land grows

Test Plan

dagit

Diff Detail

Repository
R1 dagster
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Oct 29, 6:01 PM
Harbormaster failed remote builds in B20430: Diff 24773!
yuhan edited the summary of this revision. (Show Details)

up

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Oct 30, 11:04 PM
Harbormaster failed remote builds in B20618: Diff 24982!
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Nov 4, 8:03 AM
Harbormaster failed remote builds in B20768: Diff 25171!

This mostly lgtm. I think it looks a little weird to have "null" when there's no asset metadata. What do you think about just leaving it blank instead for that situation?

python_modules/dagster/dagster/core/snap/solid.py
301

OutputDefinition now just has asset_store_key and asset_metadata, so we should probably do that here too?