Page MenuHomePhabricator
Differential D4949

Allow users to override k8s job container command
Changes PlannedPublic
Actions

Authored by sashank on Oct 29 2020, 3:21 PM.

Details

Reviewers
catherinewu
johann
rexledesma
Summary

Resolves https://github.com/dagster-io/dagster/issues/3081

Test Plan

integration
update unit tests

Diff Detail

Repository
R1 dagster
Branch
use-args-not-command-k8s
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

sashank created this revision.Oct 29 2020, 3:21 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 29 2020, 3:40 PM
Harbormaster failed remote builds in B20392: Diff 24732!
sashank updated this revision to Diff 25025.Nov 2 2020, 4:51 PM

up

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 2 2020, 5:07 PM
Harbormaster failed remote builds in B20653: Diff 25025!
sashank updated this revision to Diff 25037.Nov 2 2020, 5:34 PM

Up

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 2 2020, 5:57 PM
Harbormaster failed remote builds in B20659: Diff 25037!
sashank updated this revision to Diff 25978.Thu, Nov 19, 4:54 PM

up

sashank edited the test plan for this revision. (Show Details)Thu, Nov 19, 4:55 PM
sashank added a reviewer: catherinewu.
sashank updated this revision to Diff 25980.Thu, Nov 19, 4:55 PM

up

sashank published this revision for review.Thu, Nov 19, 4:56 PM
sashank added a reviewer: johann.
sashank added a reviewer: rexledesma.
Harbormaster failed remote builds in B21414: Diff 25978!Thu, Nov 19, 5:08 PM
Harbormaster failed remote builds in B21415: Diff 25980!Thu, Nov 19, 5:11 PM
sashank updated this revision to Diff 25983.Thu, Nov 19, 5:13 PM

up

Harbormaster failed remote builds in B21417: Diff 25983!Thu, Nov 19, 5:28 PM
sashank updated this revision to Diff 25994.Thu, Nov 19, 6:49 PM

up

Harbormaster completed remote builds in B21425: Diff 25994.Thu, Nov 19, 7:06 PM
rexledesma requested changes to this revision.Thu, Nov 19, 7:19 PM

We would also need to surface this configuration in the helm chart

This revision now requires changes to proceed.Thu, Nov 19, 7:19 PM
sashank added a comment.Thu, Nov 19, 11:49 PM

We would also need to surface this configuration in the helm chart

Could you point me to where I should be making changes?

rexledesma added a comment.Fri, Nov 20, 12:18 AM
In D4949#141512, @sashank wrote:

We would also need to surface this configuration in the helm chart

Could you point me to where I should be making changes?

@sashank You can add a field jobCommand in the values.yaml for the scheduler/launchers. Then you can thread it through the instance yaml defined in the config map, to the job_command field you defined

sashank updated this revision to Diff 26546.Mon, Nov 30, 4:46 PM

up

sashank updated this revision to Diff 26548.Mon, Nov 30, 4:57 PM

up

sashank updated this revision to Diff 26549.Mon, Nov 30, 4:57 PM

up

sashank updated this revision to Diff 26550.Mon, Nov 30, 5:01 PM

up

Harbormaster completed remote builds in B21863: Diff 26548.Mon, Nov 30, 5:13 PM
Harbormaster completed remote builds in B21864: Diff 26549.
Harbormaster failed remote builds in B21861: Diff 26546!Mon, Nov 30, 5:18 PM
Harbormaster completed remote builds in B21865: Diff 26550.
sashank updated this revision to Diff 26553.Mon, Nov 30, 5:22 PM

up

Harbormaster completed remote builds in B21868: Diff 26553.Mon, Nov 30, 5:40 PM
sashank updated this revision to Diff 26555.Mon, Nov 30, 5:42 PM

reset last updated

Harbormaster completed remote builds in B21870: Diff 26555.Mon, Nov 30, 6:00 PM
sashank edited the test plan for this revision. (Show Details)Mon, Nov 30, 6:10 PM
sashank updated this revision to Diff 26558.Mon, Nov 30, 6:10 PM

up

Harbormaster failed remote builds in B21872: Diff 26558!Mon, Nov 30, 6:47 PM
sashank planned changes to this revision.Tue, Dec 1, 4:39 AM

Revision Contents
Changeset List

PathSize
helm/
dagster/
templates/
6 lines
12 lines
integration_tests/
test_suites/
k8s-integration-test-suite/
3 lines
python_modules/
libraries/
dagster-celery-k8s/
dagster_celery_k8s/
3 lines
5 lines
dagster_celery_k8s_tests/
23 lines
dagster-k8s/
dagster_k8s/
49 lines
11 lines
10 lines

Diff 26558

View Options

helm/dagster/templates/configmap-instance.yaml

Loading...
View Options

helm/dagster/values.yaml

Loading...
View Options

integration_tests/test_suites/k8s-integration-test-suite/test_job_spec.py

Loading...
View Options

python_modules/libraries/dagster-celery-k8s/dagster_celery_k8s/executor.py

Loading...
View Options

python_modules/libraries/dagster-celery-k8s/dagster_celery_k8s/launcher.py

Loading...
View Options

python_modules/libraries/dagster-celery-k8s/dagster_celery_k8s_tests/test_launcher.py

Loading...
View Options

python_modules/libraries/dagster-k8s/dagster_k8s/job.py

Loading...
View Options

python_modules/libraries/dagster-k8s/dagster_k8s/launcher.py

Loading...
View Options

python_modules/libraries/dagster-k8s/dagster_k8s/scheduler.py

Loading...