Page MenuHomePhabricator

Allow users to override k8s job container command
Changes PlannedPublic

Authored by sashank on Oct 29 2020, 3:21 PM.

Details

Summary
Test Plan

integration
update unit tests

Diff Detail

Repository
R1 dagster
Branch
use-args-not-command-k8s
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 29 2020, 3:40 PM
Harbormaster failed remote builds in B20392: Diff 24732!
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 2 2020, 5:07 PM
Harbormaster failed remote builds in B20653: Diff 25025!
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 2 2020, 5:57 PM
Harbormaster failed remote builds in B20659: Diff 25037!
sashank added a reviewer: catherinewu.
sashank published this revision for review.Thu, Nov 19, 4:56 PM
sashank added a reviewer: johann.
sashank added a reviewer: rexledesma.

We would also need to surface this configuration in the helm chart

This revision now requires changes to proceed.Thu, Nov 19, 7:19 PM

We would also need to surface this configuration in the helm chart

Could you point me to where I should be making changes?

We would also need to surface this configuration in the helm chart

Could you point me to where I should be making changes?

@sashank You can add a field jobCommand in the values.yaml for the scheduler/launchers. Then you can thread it through the instance yaml defined in the config map, to the job_command field you defined