Page MenuHomePhabricator

kill the cli api
ClosedPublic

Authored by dgibson on Wed, Oct 28, 3:31 PM.

Details

Summary

A number of changes related to repo/pipeline/schedule origins become a lot simpler if the cli api goes away. This diff makes that happen - we can decide when we are comfortable doing this. Since 0.9.16 all users are no longer using the cli api by default, so this should be an invisible change to end users.

Test Plan

BK + Azure

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Oct 28, 5:33 PM
Harbormaster failed remote builds in B20307: Diff 24638!
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Oct 28, 10:38 PM
Harbormaster failed remote builds in B20360: Diff 24695!
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Oct 28, 11:35 PM
Harbormaster failed remote builds in B20371: Diff 24706!

redparty

im up for landing fri/mon and letting it go out next week - will leave open for more opinions

yeah let's definitely not sneak this into a release at the last minute

def support landing this

This revision is now accepted and ready to land.Fri, Oct 30, 8:34 PM
This revision was landed with ongoing or failed builds.Mon, Nov 2, 5:25 PM
Closed by commit R1:623b082dd56a: kill the cli api (authored by dgibson). · Explain Why
This revision was automatically updated to reflect the committed changes.