Page MenuHomePhabricator

Store repo location loading errors on the workspace, take errors into account when loading and reloading repo locations
ClosedPublic

Authored by dgibson on Oct 27 2020, 6:52 PM.

Details

Test Plan

BK, introduce an error into a repository and reload, see a graphql error (need @dish's UI changes to get the full effect here). Test normal reload flow works with no error

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 27 2020, 7:11 PM
Harbormaster failed remote builds in B20250: Diff 24569!
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 27 2020, 8:42 PM
Harbormaster failed remote builds in B20260: Diff 24579!
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 27 2020, 9:20 PM
Harbormaster failed remote builds in B20269: Diff 24590!
dgibson added a subscriber: dish.

TEST PLAN
BK

does current dagit reload flows all work fine still with this diff or does a frontend change need to go in with it ?

I'm working on a nicer way to surface these errors in the UI, but as part of the overall nav structure changes.

I don't want to block this fix on those changes, so I can try to do something a little hacky within the current UI to at least make things usable again.

queue management - request review with updated test plan if this is good to land

This revision now requires changes to proceed.Oct 29 2020, 6:36 PM

rebase after a make dev_install

This revision is now accepted and ready to land.Mon, Nov 2, 5:09 PM