Depends on D5748
As the title, enumify the helm scheduler values, rather
than relying on a boolean toggle.
Differential D4920 Authored by • rexledesma on Oct 27 2020, 5:52 PM.
Details Summary Depends on D5748 As the title, enumify the helm scheduler values, rather Test Plan bk/helm lint
Diff Detail
Event TimelineHarbormaster completed remote builds in B20237: Diff 24554.Oct 27 2020, 6:12 PM2020-10-27 18:12:14 (UTC+0) • rexledesma retitled this revision from [3/n] Add schema for scheduler to [2/n] Add helm schema for Scheduler configuration.Oct 28 2020, 12:20 AM2020-10-28 00:20:07 (UTC+0) • rexledesma added a parent revision: D4895: [1/n] Add helm schema validation for Dagit configuration. Harbormaster completed remote builds in B20287: Diff 24615.Oct 28 2020, 12:35 AM2020-10-28 00:35:58 (UTC+0) Harbormaster completed remote builds in B20290: Diff 24619.Oct 28 2020, 1:05 AM2020-10-28 01:05:12 (UTC+0) • rexledesma retitled this revision from [2/n] Add helm schema for Scheduler configuration to [2/n] Add helm schema validation for Scheduler configuration.Oct 28 2020, 1:28 AM2020-10-28 01:28:27 (UTC+0) Harbormaster completed remote builds in B20294: Diff 24623.Oct 28 2020, 1:38 AM2020-10-28 01:38:22 (UTC+0) Harbormaster completed remote builds in B20296: Diff 24625.Oct 28 2020, 1:40 AM2020-10-28 01:40:27 (UTC+0) Harbormaster completed remote builds in B20297: Diff 24626.Oct 28 2020, 1:43 AM2020-10-28 01:43:01 (UTC+0) Harbormaster completed remote builds in B20295: Diff 24624.Oct 28 2020, 1:50 AM2020-10-28 01:50:17 (UTC+0) • rexledesma added inline comments.
Harbormaster completed remote builds in B20343: Diff 24677.Oct 28 2020, 7:03 PM2020-10-28 19:03:37 (UTC+0) alangenfeld added inline comments. This revision now requires changes to proceed.Oct 29 2020, 6:29 PM2020-10-29 18:29:00 (UTC+0) • rexledesma removed reviewers: Restricted Project, alangenfeld.Nov 2 2020, 7:35 PM2020-11-02 19:35:46 (UTC+0) Comment ActionsWill wait until cherry pick mode to land this - removing reviewers for now This revision now requires review to proceed.Nov 2 2020, 7:35 PM2020-11-02 19:35:46 (UTC+0) • rexledesma updated this revision to Diff 27653.Edited · Dec 12 2020, 6:34 AM2020-12-12 06:34:38 (UTC+0) Comment Actionsresurrect from the dead • rexledesma edited the test plan for this revision. (Show Details)Dec 12 2020, 6:35 AM2020-12-12 06:35:53 (UTC+0) Harbormaster completed remote builds in B22735: Diff 27653.Dec 12 2020, 6:52 AM2020-12-12 06:52:41 (UTC+0) Harbormaster failed remote builds in B22737: Diff 27655!Dec 12 2020, 6:59 AM2020-12-12 06:59:34 (UTC+0) Harbormaster failed remote builds in B23695: Diff 28818!Jan 6 2021, 4:54 AM2021-01-06 04:54:29 (UTC+0) • rexledesma retitled this revision from [2/n] Add helm schema validation for Scheduler configuration to Update Scheduler helm schema to use enum types.Jan 6 2021, 5:01 AM2021-01-06 05:01:19 (UTC+0) Harbormaster failed remote builds in B23709: Diff 28832!Jan 6 2021, 9:40 AM2021-01-06 09:40:08 (UTC+0) Harbormaster failed remote builds in B23710: Diff 28833!Jan 6 2021, 9:43 AM2021-01-06 09:43:00 (UTC+0) Harbormaster failed remote builds in B23711: Diff 28834!Jan 6 2021, 9:53 AM2021-01-06 09:53:24 (UTC+0) Harbormaster failed remote builds in B23712: Diff 28835!Jan 6 2021, 10:03 AM2021-01-06 10:03:44 (UTC+0) Harbormaster completed remote builds in B23714: Diff 28837.Jan 6 2021, 10:11 AM2021-01-06 10:11:37 (UTC+0) Harbormaster completed remote builds in B23715: Diff 28838.Jan 6 2021, 10:23 AM2021-01-06 10:23:11 (UTC+0) • rexledesma added reviewers: • nate, • catherinewu, alangenfeld.Jan 6 2021, 7:08 PM2021-01-06 19:08:28 (UTC+0) • rexledesma added a child revision: Restricted Differential Revision.Jan 8 2021, 4:54 PM2021-01-08 16:54:43 (UTC+0) alangenfeld added inline comments.
This revision is now accepted and ready to land.Jan 8 2021, 7:31 PM2021-01-08 19:31:37 (UTC+0) Closed by commit R1:fa9dbe5977a0: Update Scheduler helm schema to use enum types (authored by • rexledesma). · Explain WhyJan 8 2021, 11:22 PM2021-01-08 23:22:09 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 24623 python_modules/automation/automation/docker/images/buildkite-integration/snapshot-reqs-2.7.18.txtLoading... python_modules/automation/automation/docker/images/buildkite-unit-snapshot-builder/DockerfileLoading... python_modules/automation/automation/docker/images/buildkite-unit/snapshot-reqs-2.7.18.txtLoading... python_modules/automation/automation/docker/images/buildkite-unit/snapshot-reqs-3.6.11.txtLoading... python_modules/dagster/dagster_tests/core_tests/config_types_tests/evaluator_tests/test_composite_descent.pyLoading... python_modules/dagster/dagster_tests/core_tests/definitions_tests/test_definition_errors.pyLoading... python_modules/dagster/dagster_tests/general_tests/compat_tests/test_change_snapshot_structure.pyLoading... |