Details

Reviewers

• nate
• catherinewu
alangenfeld

Commits

R1:fa9dbe5977a0: Update Scheduler helm schema to use enum types

Summary

Depends on D5748

As the title, enumify the helm scheduler values, rather
than relying on a boolean toggle.

Test Plan

bk/helm lint
integration

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• rexledesma created this revision.Oct 27 2020, 5:52 PM

Harbormaster completed remote builds in B20237: Diff 24554.Oct 27 2020, 6:12 PM

• rexledesma requested review of this revision.Oct 27 2020, 6:12 PM

use pydantic DSL

• rexledesma retitled this revision from [3/n] Add schema for scheduler to [2/n] Add helm schema for Scheduler configuration.Oct 28 2020, 12:20 AM

• rexledesma edited the summary of this revision. (Show Details)

• rexledesma added a parent revision: D4895: [1/n] Add helm schema validation for Dagit configuration.

Harbormaster completed remote builds in B20287: Diff 24615.Oct 28 2020, 12:35 AM

rebase

Harbormaster completed remote builds in B20290: Diff 24619.Oct 28 2020, 1:05 AM

rebase

• rexledesma retitled this revision from [2/n] Add helm schema for Scheduler configuration to [2/n] Add helm schema validation for Scheduler configuration.Oct 28 2020, 1:28 AM

Harbormaster completed remote builds in B20294: Diff 24623.Oct 28 2020, 1:38 AM

Harbormaster completed remote builds in B20296: Diff 24625.Oct 28 2020, 1:40 AM

Harbormaster completed remote builds in B20297: Diff 24626.Oct 28 2020, 1:43 AM

Harbormaster completed remote builds in B20295: Diff 24624.Oct 28 2020, 1:50 AM

rebase

• rexledesma added a reviewer: Restricted Project.Oct 28 2020, 6:52 PM

• rexledesma added inline comments.

python_modules/automation/automation/helm/schema/scheduler.py
38 ↗	(On Diff #24677)	support for conditional schemas isn't first class in pydantic so we'll have to override the schema here (https://github.com/samuelcolvin/pydantic/issues/529)

Harbormaster completed remote builds in B20343: Diff 24677.Oct 28 2020, 7:03 PM

alangenfeld added a subscriber: alangenfeld.Oct 28 2020, 11:06 PM

alangenfeld added inline comments.

helm/dagster/templates/configmap-instance.yaml
12–13	this is a breaking change right? do we want to do that ahead of `0.10.0`?
python_modules/automation/automation/helm/schema/scheduler.py
38 ↗	(On Diff #24677)	maybe leave this is a comment in the code

separate out breaking changes from things we can schema-tize without breaking

This revision now requires changes to proceed.Oct 29 2020, 6:29 PM

Will wait until cherry pick mode to land this - removing reviewers for now

This revision now requires review to proceed.Nov 2 2020, 7:35 PM

necro

resurrect from the dead

• rexledesma edited the test plan for this revision. (Show Details)Dec 12 2020, 6:35 AM

• rexledesma removed a subscriber: alangenfeld.

integration tests

Harbormaster completed remote builds in B22735: Diff 27653.Dec 12 2020, 6:52 AM

Harbormaster failed remote builds in B22737: Diff 27655!Dec 12 2020, 6:59 AM

make sure to document all the breaking changes in changes.md and migration.md

Harbormaster failed remote builds in B23695: Diff 28818!Jan 6 2021, 4:54 AM

• rexledesma retitled this revision from [2/n] Add helm schema validation for Scheduler configuration to Update Scheduler helm schema to use enum types.Jan 6 2021, 5:01 AM

• rexledesma edited the summary of this revision. (Show Details)