Page MenuHomePhabricator

[run-queue-7] Switch Dagit to use submit_run
ClosedPublic

Authored by johann on Oct 27 2020, 5:18 PM.

Details

Summary

The first changeover of a launch_run callsite. This should be safe to land, because with the LaunchImmediateRunCoordinator as default, changing the call site just adds a layer of indirection.

Test Plan

Not familiar with grapqhql or dagit tests, could use some pointers here. I assume there is an existing test for launch_pipeline_execution in graphql but I haven't found it.

Manually: verified that both Coordinators can be used to launch runs from Dagit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 27 2020, 7:06 PM
Harbormaster failed remote builds in B20230: Diff 24547!
johann retitled this revision from [run-queue-7] graphql invocation to [run-queue-7] Switch Dagit to use submit_run.Fri, Oct 30, 9:30 PM
johann edited the summary of this revision. (Show Details)
johann edited the test plan for this revision. (Show Details)
johann added reviewers: alangenfeld, dgibson.
alangenfeld added inline comments.
python_modules/dagster-graphql/dagster_graphql/implementation/execution/launch_execution.py
11–40

dont love this being subtly out of sync (everything called launch but its doing submit) - leave a comment block or gh issue link or something

This revision is now accepted and ready to land.Mon, Nov 2, 5:19 PM
This revision was automatically updated to reflect the committed changes.