With the RepositoryLocationOrigin class introduced in https://dagster.phacility.com/D4916 we can make the handle class constructors just all take in an origin, do the creation in the constructor, and eliminate these unneeded static factory methods. Nothe main goal of creating the class (which was to make it possible to reload repositories that failed to load), but cleans things up a bit too.
Details
Details
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
| python_modules/dagster/dagster/core/host_representation/handle.py | ||
|---|---|---|
| 1–2 | this file looks like a lot but is just moving logic out of the factory and into the actual constructor of the class | |
