Page MenuHomePhabricator
Differential D4918

Remove RepositoryLocationHandle static constructors, use RepositoryLocationOrigin instead
ClosedPublic
Actions

Authored by dgibson on Oct 27 2020, 4:05 PM.

Details

Reviewers
alangenfeld
sashank
schrockn
prha
Commits
R1:a93a95633a47: Remove RepositoryLocationHandle static constructors, use…
Summary

With the RepositoryLocationOrigin class introduced in https://dagster.phacility.com/D4916 we can make the handle class constructors just all take in an origin, do the creation in the constructor, and eliminate these unneeded static factory methods. Nothe main goal of creating the class (which was to make it possible to reload repositories that failed to load), but cleans things up a bit too.

Test Plan

BK

Diff Detail

Repository
R1 dagster
Branch
load15
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

dgibson created this revision.Oct 27 2020, 4:05 PM
dgibson added inline comments.Oct 27 2020, 4:07 PM
python_modules/dagster/dagster/core/host_representation/handle.py
1–2

this file looks like a lot but is just moving logic out of the factory and into the actual constructor of the class

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 27 2020, 4:31 PM
Harbormaster failed remote builds in B20222: Diff 24539!
dgibson updated this revision to Diff 24544.Oct 27 2020, 4:57 PM

up

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 27 2020, 5:28 PM
Harbormaster failed remote builds in B20227: Diff 24544!
dgibson updated this revision to Diff 24556.Oct 27 2020, 6:03 PM

test fixes

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 27 2020, 6:22 PM
Harbormaster failed remote builds in B20239: Diff 24556!
dgibson updated this revision to Diff 24562.Oct 27 2020, 6:29 PM

up

Harbormaster completed remote builds in B20243: Diff 24562.Oct 27 2020, 6:47 PM
dgibson requested review of this revision.Oct 27 2020, 6:47 PM
alangenfeld accepted this revision.Oct 28 2020, 11:03 PM

cleanup

This revision is now accepted and ready to land.Oct 28 2020, 11:03 PM
dgibson updated this revision to Diff 24967.Oct 30 2020, 7:58 PM

up

Harbormaster completed remote builds in B20603: Diff 24967.Oct 30 2020, 8:17 PM
dgibson updated this revision to Diff 25015.Nov 2 2020, 2:35 PM

up

Harbormaster failed remote builds in B20644: Diff 25015!Nov 2 2020, 2:59 PM
This revision was landed with ongoing or failed builds.Nov 2 2020, 5:05 PM
Closed by commit R1:a93a95633a47: Remove RepositoryLocationHandle static constructors, use… (authored by dgibson). · Explain Why
This revision was automatically updated to reflect the committed changes.
dgibson added a commit: R1:a93a95633a47: Remove RepositoryLocationHandle static constructors, use….

Revision Contents
Changeset List

PathSize
python_modules/
dagster-graphql/
dagster_graphql/
test/
4 lines
dagster_graphql_tests/
graphql/
2 lines
dagster-test/
dagster_test/
dagster_core_docker_buildkite/
20 lines
test_project/
19 lines
dagster/
dagster/
cli/
workspace/
7 lines
core/
host_representation/
278 lines
8 lines
17 lines
dagster_tests/
api_tests/
22 lines
core_tests/
launcher_tests/
10 lines
libraries/
dagster-dask/
dagster_dask_tests/
3 lines

Diff 24539

View Options

python_modules/dagster-graphql/dagster_graphql/test/utils.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/graphql_context_test_suite.py

Loading...
View Options

python_modules/dagster-test/dagster_test/dagster_core_docker_buildkite/__init__.py

Loading...
View Options

python_modules/dagster-test/dagster_test/test_project/__init__.py

Loading...
View Options

python_modules/dagster/dagster/cli/workspace/load.py

Loading...
View Options

python_modules/dagster/dagster/core/host_representation/handle.py

Loading...
View Options

python_modules/dagster/dagster/core/host_representation/origin.py

Loading...
View Options

python_modules/dagster/dagster/core/host_representation/repository_location.py

Loading...
View Options

python_modules/dagster/dagster_tests/api_tests/utils.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/launcher_tests/test_cli_api_running_multiprocessing.py

Loading...
View Options

python_modules/libraries/dagster-dask/dagster_dask_tests/test_graphql.py

Loading...