Page MenuHomePhabricator

Remove RepositoryLocationHandle static constructors, use RepositoryLocationOrigin instead
ClosedPublic

Authored by dgibson on Oct 27 2020, 4:05 PM.

Details

Summary

With the RepositoryLocationOrigin class introduced in https://dagster.phacility.com/D4916 we can make the handle class constructors just all take in an origin, do the creation in the constructor, and eliminate these unneeded static factory methods. Nothe main goal of creating the class (which was to make it possible to reload repositories that failed to load), but cleans things up a bit too.

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

python_modules/dagster/dagster/core/host_representation/handle.py
1–2

this file looks like a lot but is just moving logic out of the factory and into the actual constructor of the class

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 27 2020, 4:31 PM
Harbormaster failed remote builds in B20222: Diff 24539!
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 27 2020, 5:28 PM
Harbormaster failed remote builds in B20227: Diff 24544!
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 27 2020, 6:22 PM
Harbormaster failed remote builds in B20239: Diff 24556!
This revision is now accepted and ready to land.Oct 28 2020, 11:03 PM
This revision was landed with ongoing or failed builds.Mon, Nov 2, 5:05 PM
This revision was automatically updated to reflect the committed changes.