Page MenuHomeElementl
Differential D4909

Fix for test_streaming_terminate
ClosedPublic
Actions

Authored by • dgibson on Oct 26 2020, 7:41 PM.
Tags
None
Referenced Files
F2991307: D4909.diff
Sat, Jun 10, 9:21 PM
Unknown Object (File)
Wed, May 31, 6:57 AM
Unknown Object (File)
Apr 4 2023, 11:57 AM
Unknown Object (File)
Apr 3 2023, 2:58 PM
Unknown Object (File)
Mar 31 2023, 12:34 AM
Unknown Object (File)
Mar 30 2023, 8:50 AM
Unknown Object (File)
Feb 14 2023, 6:28 AM
Unknown Object (File)
Dec 24 2022, 11:24 PM
View All 30 Files
Subscribers
None

Details

Reviewers
alangenfeld
• max
Commits
R1:1ae5d9e91edd: Fix for test_streaming_terminate
Summary

Sometimes a shutdown_server call happens so fast that it kills the messenger that shut it down. We already account for this in EphemeralApiClient.cleanup_server, add similar logic to this test.

Test Plan

BK

Diff Detail

Repository
R1 dagster
Branch
streamterm (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

• dgibson created this revision.Oct 26 2020, 7:41 PM
• dgibson published this revision for review.Oct 26 2020, 7:41 PM
• dgibson mentioned this in D4908: disable test_streaming_terminate.
alangenfeld accepted this revision.Oct 26 2020, 7:43 PM
This revision is now accepted and ready to land.Oct 26 2020, 7:43 PM
This revision was landed with ongoing or failed builds.Oct 26 2020, 7:57 PM
Closed by commit R1:1ae5d9e91edd: Fix for test_streaming_terminate (authored by • dgibson). · Explain Why
This revision was automatically updated to reflect the committed changes.
• dgibson added a commit: R1:1ae5d9e91edd: Fix for test_streaming_terminate.
Harbormaster failed remote builds in B20166: Diff 24477!Oct 26 2020, 7:58 PM

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster_tests/
general_tests/
grpc_tests/
11 lines

Diff 24477

View Options

python_modules/dagster/dagster_tests/general_tests/grpc_tests/test_server.py

Loading...