Bump up default timeout for waiting for gRPC server
ClosedPublic
Actions

Authored by • dgibson on Oct 26 2020, 6:49 PM.

Details

Reviewers

alangenfeld
• max
• sashank

Commits

R1:09b77f3e71ac: Bump up default timeout for waiting for gRPC server

Summary

3 seconds is quite aggressive for a process that can involve loading user code (and is manifesting as such in flaky tests on Windows). Bump up to 15 seconds.

Test Plan

BK + Azure

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• dgibson created this revision.Oct 26 2020, 6:49 PM

• dgibson edited the summary of this revision. (Show Details)Oct 26 2020, 6:53 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 26 2020, 7:13 PM

Harbormaster failed remote builds in B20158: Diff 24466!

test failure unrelated

alangenfeld accepted this revision.Oct 26 2020, 7:45 PM

This revision is now accepted and ready to land.Oct 26 2020, 7:45 PM

test failure unrelated

I think i have a fix for this in master - looks like this rev is based on last wed

This revision was landed with ongoing or failed builds.Oct 26 2020, 7:56 PM

Closed by commit R1:09b77f3e71ac: Bump up default timeout for waiting for gRPC server (authored by • dgibson). · Explain Why

This revision was automatically updated to reflect the committed changes.

• dgibson added a commit: R1:09b77f3e71ac: Bump up default timeout for waiting for gRPC server.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

grpc/

server.py

2 lines

Diff 24480

View Options

python_modules/dagster/dagster/grpc/server.py

Bump up default timeout for waiting for gRPC serverClosedPublicActions