Page MenuHomeElementl
Differential D4888

(make-pipeline-a-solid-3) Eliminate IContainsSolid
ClosedPublic
Actions

Authored by schrockn on Oct 23 2020, 8:29 PM.

Details

Reviewers
alangenfeld
max
dgibson
sandyryza
Commits
R1:7b130a53edd7: (make-pipeline-a-solid-3) Eliminate IContainsSolid
Summary

This interface is pointless now that we have GraphDefinition

Depends on D4882

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schrockn created this revision.Oct 23 2020, 8:29 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 23 2020, 8:46 PM
Harbormaster failed remote builds in B20098: Diff 24390!
schrockn updated this revision to Diff 24394.Oct 23 2020, 9:02 PM

up

schrockn mentioned this in D4847: (make-pipeline-a-solid-1) Allow pipeline to be used as composite_solid.Oct 23 2020, 9:31 PM
Harbormaster completed remote builds in B20102: Diff 24394.Oct 23 2020, 9:43 PM
schrockn requested review of this revision.Oct 23 2020, 9:43 PM
alangenfeld accepted this revision.Oct 23 2020, 9:57 PM
This revision is now accepted and ready to land.Oct 23 2020, 9:57 PM
schrockn updated this revision to Diff 24488.Oct 26 2020, 9:15 PM

rebase

schrockn added a child revision: D4912: (make-pipeline-a-solid-4) Rename ISolidDefinition to NodeDefinition and spread name through composition process for code clarity.Oct 26 2020, 9:34 PM
Harbormaster completed remote builds in B20175: Diff 24488.Oct 26 2020, 9:35 PM
Closed by commit R1:7b130a53edd7: (make-pipeline-a-solid-3) Eliminate IContainsSolid (authored by schrockn). · Explain WhyOct 27 2020, 8:57 PM
This revision was automatically updated to reflect the committed changes.
schrockn added a commit: R1:7b130a53edd7: (make-pipeline-a-solid-3) Eliminate IContainsSolid.

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
core/
definitions/
2 lines
53 lines
44 lines
execution/
11 lines
snap/
6 lines
dagster_tests/
core_tests/
2 lines

Diff 24593

View Options

python_modules/dagster/dagster/core/definitions/__init__.py

Loading...
View Options

python_modules/dagster/dagster/core/definitions/graph.py

Loading...
View Options

python_modules/dagster/dagster/core/definitions/solid_container.py

Loading...
View Options

python_modules/dagster/dagster/core/execution/results.py

Loading...
View Options

python_modules/dagster/dagster/core/snap/dep_snapshot.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/test_pipeline_execution.py

Loading...