Page MenuHomeElementl
Differential D4882

(make-pipeline-a-solid-2) container_definition --> graph_definition
ClosedPublic
Actions

Authored by • schrockn on Oct 23 2020, 2:31 AM.
Tags
None
Referenced Files
F2770136: D4882.diff
Tue, Jan 31, 12:38 PM
Unknown Object (File)
Thu, Jan 26, 1:31 PM
Unknown Object (File)
Wed, Jan 25, 5:31 PM
Unknown Object (File)
Fri, Jan 20, 1:23 PM
Unknown Object (File)
Mon, Jan 16, 1:40 PM
Unknown Object (File)
Mon, Jan 16, 2:22 AM
Unknown Object (File)
Thu, Jan 5, 3:56 PM
Unknown Object (File)
Dec 31 2022, 4:46 PM
View All 65 Files
Subscribers
None

Details

Reviewers
alangenfeld
• max
• dgibson
• sandyryza
Commits
R1:9b9efb428311: (make-pipeline-a-solid-2) container_definition --> graph_definition
Summary

Rename container_definition to graph_definition and make it required
in Solid.

Depends on D4847

Test Plan

BK

Diff Detail

Repository
R1 dagster
Branch
make-pipeline-a-solid-2
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

• schrockn updated this revision to Diff 24342.Oct 23 2020, 2:31 AM
• schrockn created this revision.

up

Harbormaster completed remote builds in B20058: Diff 24341.Oct 23 2020, 2:52 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 23 2020, 3:10 AM
Harbormaster failed remote builds in B20059: Diff 24342!
• schrockn updated this revision to Diff 24389.Oct 23 2020, 8:28 PM
• schrockn edited the summary of this revision. (Show Details)
• schrockn added reviewers: alangenfeld, • max, • dgibson, • sandyryza.

up

• schrockn added a child revision: D4888: (make-pipeline-a-solid-3) Eliminate IContainsSolid.Oct 23 2020, 8:29 PM
Harbormaster completed remote builds in B20097: Diff 24389.Oct 23 2020, 9:19 PM
• schrockn requested review of this revision.Oct 23 2020, 9:19 PM
• sandyryza accepted this revision.Oct 23 2020, 9:27 PM

This seems straightforward

This revision is now accepted and ready to land.Oct 23 2020, 9:27 PM
• schrockn updated this revision to Diff 24487.Oct 26 2020, 9:14 PM

rebase

Harbormaster completed remote builds in B20174: Diff 24487.Oct 26 2020, 9:33 PM
Closed by commit R1:9b9efb428311: (make-pipeline-a-solid-2) container_definition --> graph_definition (authored by • schrockn). · Explain WhyOct 27 2020, 8:57 PM
This revision was automatically updated to reflect the committed changes.
• schrockn added a commit: R1:9b9efb428311: (make-pipeline-a-solid-2) container_definition --> graph_definition.

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
core/
definitions/
13 lines
2 lines
12 lines
dagster_tests/
core_tests/
5 lines

Diff 24342

View Options

python_modules/dagster/dagster/core/definitions/dependency.py

Loading...
View Options

python_modules/dagster/dagster/core/definitions/graph.py

Loading...
View Options

python_modules/dagster/dagster/core/definitions/solid_container.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/test_pipeline_execution.py

Loading...