Page MenuHomePhabricator

[run-queue-2] Queued run status
ClosedPublic

Authored by johann on Oct 22 2020, 12:38 AM.

Details

Summary

New run status. Any run with queued state must also have a specified pipeline_origin

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 22 2020, 2:01 AM
Harbormaster failed remote builds in B19977: Diff 24243!
johann retitled this revision from [run-queue-2] queued run status to [run-queue-2] Queued run status.Oct 23 2020, 6:12 PM
johann edited the summary of this revision. (Show Details)
johann added reviewers: dgibson, alangenfeld.

see inline for small things related to the test

python_modules/dagster/dagster_tests/core_tests/storage_tests/test_pipeline_run.py
8–14

Making a fake pipeline origin using the real class isn't hard (something like

PipelinePythonOrigin('fake_pipeline', RepositoryPythonOrigin(sys.executable, ModuleCodePointer("fake", "fake")))

can we do that instead

17

test_queued_pipeline_origin_check?

This revision is now accepted and ready to land.Oct 26 2020, 1:20 PM

add queued to run status tag

This revision was automatically updated to reflect the committed changes.