Page MenuHomePhabricator

[run-queue 1] Add PipelineOrigin to PipelineRun
ClosedPublic

Authored by johann on Oct 22 2020, 12:04 AM.

Details

Summary

The new field is optional, because getting an origin for some existing callsites could be tricky. The origin will only be required when a pipeline will be sent to the queuing process- verified in later diff.

Test Plan

existing

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

johann retitled this revision from add pipeline_origin to pipeline run to [run-queue 1] Add PipelineOrigin to PipelineRun.Oct 22 2020, 12:11 AM
johann edited the summary of this revision. (Show Details)
johann added reviewers: alangenfeld, dgibson.

A test that verifies that a created run with this parameter set then has its pipeline_origin set would be cool, but that could also happen in the diff that adds enqueue_run and actually uses it

python_modules/dagster/dagster/core/instance/__init__.py
768–785

not for this diff, I think the end state here is a new enqueue_run method where pipeline_origin is required - and every existing callsite of create_run outside of tests (and the callsite inside DagsterInstance that's called during synchronous pipeline execution) calls enqueue_run instead

This revision is now accepted and ready to land.Oct 22 2020, 4:50 PM

pipeline_origin->external_pipeline_origin