Page MenuHomePhabricator

(1/n k8s-pod-deletion) Add event specific data to STEP_RESTARTED events
AbandonedPublic

Authored by sashank on Oct 21 2020, 2:58 PM.

Details

Reviewers
alangenfeld
Group Reviewers
Restricted Project
Summary

This diff adds event specific data to STEP_RESTARTED events with the attempt number. I actually ended up not needing this (I was able to count the number of STEP_RESTARTED event instead), but it seems nice to have as event specific data instead just having it encoded in the event message.

Test Plan

unit

Diff Detail

Repository
R1 dagster
Branch
k8s-pod-deletion-1
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

Happy to abandon if not needed

Yea this seems like a good thing to include - just need to make sure we gracefully parse old restarted events that don't have the specific data, I dont think any of the existing load-old-stuff tests have restarts

add a test - you can use the debug payloads, https://dagster.phacility.com/D4768 is a recent example

python_modules/dagster/dagster/core/events/__init__.py
109–110

i think this will fail and needs to be opt_inst

This revision now requires changes to proceed.Oct 21 2020, 10:20 PM

Ended up not being necessary