Page MenuHomeElementl

Speed up the scheduler tests by not checking every test against CLI API and gRPC repos
ClosedPublic

Authored by dgibson on Oct 20 2020, 9:07 PM.

Details

Summary

We have other test coverage that makes sure that cli and gRPC both can launch runs (plus cli api is no longer the default and will be removed at some point hopefully fairly soon). This diff makes it so that the scheduler tests only run against one external repo, dramatically speeeding up run time.

Test Plan

BK, scheduler tests now run comfortably under 10 minutes

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dgibson retitled this revision from Try taking out the cli_api tests to see if it speeds up the scheduler tests to Speed up the scheduler tests by not checking every test against CLI API and gRPC repos.
dgibson edited the summary of this revision. (Show Details)
dgibson edited the test plan for this revision. (Show Details)
dgibson added reviewers: max, alangenfeld.

up

This revision is now accepted and ready to land.Oct 20 2020, 9:30 PM