Page MenuHomeElementl

RFC: rename executable => job
ClosedPublic

Authored by prha on Oct 20 2020, 8:27 PM.
Tags
None
Referenced Files
F2431689: D4837.id24275.diff
Sun, Aug 14, 3:59 AM
F2431492: D4837.id24279.diff
Sun, Aug 14, 1:34 AM
Unknown Object (File)
Fri, Aug 12, 5:57 PM
Unknown Object (File)
Thu, Aug 11, 5:26 PM
Unknown Object (File)
Wed, Aug 10, 8:08 AM
Unknown Object (File)
Fri, Aug 5, 8:30 AM
Unknown Object (File)
Mon, Aug 1, 5:20 AM
Unknown Object (File)
Fri, Jul 29, 12:11 AM
Subscribers
None

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

prha retitled this revision from rename executable => job to RFC: rename executable => job.Oct 21 2020, 3:07 PM
python_modules/dagster/dagster/core/host_representation/external_data.py
55–60

I forget if it was this part or a different one - but I think the last rename we did ended up causing breakages for people who were not version synced across their whole deployment. We don't claim version flexibility - but it sucks to cause breakages for not-yet-used features.

Not sure if its better to =None the param and make it an opt_list since that can basically hide information loss in desynced versions, but figured I would call it out

python_modules/dagster/dagster/core/host_representation/external_data.py
55–60

oh, that's a good call-out...

I assume that it'll be safe to remove the param after a couple versions though?

python_modules/dagster/dagster/core/host_representation/external_data.py
55–60

ya its not clear since this is just us trying to be generously flexible and not break without a good reason.

I think one approach is to try to be flexible until this Job stuff is more ready to go end to end, then make it hard required

making it None makes sense to me esp for an unreleased feature, but we should track making it non-None?

This revision is now accepted and ready to land.Oct 22 2020, 4:57 PM

make new params, old params optional in ExternalRepositoryData

I think this is an improvement and I also like that its only 3 letters

This revision was automatically updated to reflect the committed changes.