Page MenuHomePhabricator

RFC: Sort dagster imports with other third party libraries
ClosedPublic

Authored by max on Oct 20 2020, 6:51 PM.

Details

Summary

Our custom isort parameters have been an impediment to contributors, especially with the PR interface. This change would sort dagster imports with other third party libraries. Alternatively, we could sort all imports from dagster libraries together, separate from third party libraries, but this has been rejected in the past because of difficulties with drift.

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2020, 7:09 PM
Harbormaster failed remote builds in B19865: Diff 24100!

try upgrading pytest machinery

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2020, 7:41 PM
Harbormaster failed remote builds in B19867: Diff 24104!
max edited the summary of this revision. (Show Details)

up

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Oct 27, 8:06 PM
Harbormaster failed remote builds in B20257: Diff 24576!
max requested review of this revision.Tue, Oct 27, 9:33 PM
.isort.cfg
4

this is the actual change in this diff

This revision is now accepted and ready to land.Tue, Oct 27, 9:37 PM

Is this really the true source of the contributor problem? We are going to have customized lint and formatting rules in the project generally.

I think I am agnostic on this change. It seems a bit weird in dagster core but we can always go back.

but this seems good for contributor love and we can always switch back easily. yay tooling